-
Notifications
You must be signed in to change notification settings - Fork 177
Remove stsci.image dependency #8663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8663 +/- ##
=======================================
Coverage 60.36% 60.36%
=======================================
Files 372 372
Lines 38325 38326 +1
=======================================
+ Hits 23136 23137 +1
Misses 15189 15189 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me - it looks like the last remaining use of stsci.image was removed with #7590.
Can you please fix the conflict with the change log?
Thanks for taking a look! I can certainly resolve the changelog entry. Any objection to waiting until this is approved (as merging other PRs will likely re-introduce a changelog entry conflict until something like #8671 can be implemented)? |
No objection. I approve otherwise! |
Thanks! Conflict fixed. |
The I opened a test PR here to make sure this isn't due to changes in this PR, it has the same build errors: |
Thanks for filing that - I noticed the failed builds this morning as well. |
Thanks! Maybe we should finish support for 3.12 first 😆 |
stsci.image
is listed as a dependency:jwst/pyproject.toml
Line 40 in de39de0
but is unused:
https://github.com/search?q=repo%3Aspacetelescope%2Fjwst%20stsci.image&type=code
Regression tests with this PR show that stsci.image is not installed (so it is also not a non-primary dependency): https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1611/pipeline#step-192-log-94
and all tests passed.
Fixes: #3576
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR