Skip to content

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jul 21, 2024

stsci.image is listed as a dependency:

"stsci.image>=2.3.5",

but is unused:
https://github.com/search?q=repo%3Aspacetelescope%2Fjwst%20stsci.image&type=code

Regression tests with this PR show that stsci.image is not installed (so it is also not a non-primary dependency): https://plwishmaster.stsci.edu:8081/blue/organizations/jenkins/RT%2FJWST-Developers-Pull-Requests/detail/JWST-Developers-Pull-Requests/1611/pipeline#step-192-log-94

and all tests passed.

Fixes: #3576

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.36%. Comparing base (4c50426) to head (155408f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8663   +/-   ##
=======================================
  Coverage   60.36%   60.36%           
=======================================
  Files         372      372           
  Lines       38325    38326    +1     
=======================================
+ Hits        23136    23137    +1     
  Misses      15189    15189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram changed the title TEST: remove stsci.image dependency Remove stsci.image dependency Jul 22, 2024
@braingram braingram marked this pull request as ready for review July 22, 2024 16:16
@braingram braingram requested a review from a team as a code owner July 22, 2024 16:16
@braingram braingram requested review from nden and melanieclarke July 23, 2024 19:22
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me - it looks like the last remaining use of stsci.image was removed with #7590.

Can you please fix the conflict with the change log?

@braingram
Copy link
Collaborator Author

Thanks for taking a look!

I can certainly resolve the changelog entry. Any objection to waiting until this is approved (as merging other PRs will likely re-introduce a changelog entry conflict until something like #8671 can be implemented)?

@melanieclarke
Copy link
Collaborator

No objection. I approve otherwise!

@braingram
Copy link
Collaborator Author

Thanks! Conflict fixed.

@braingram braingram enabled auto-merge August 6, 2024 14:18
@braingram braingram disabled auto-merge August 6, 2024 14:42
@braingram
Copy link
Collaborator Author

The build CI errors here are likely due to a new cibuildwheel which is by default building python 3.13 wheels (which are failing test for jwst).
https://github.com/pypa/cibuildwheel/releases/tag/v2.20.0

I opened a test PR here to make sure this isn't due to changes in this PR, it has the same build errors:
#8689

@braingram braingram merged commit 33e248c into spacetelescope:master Aug 6, 2024
24 of 27 checks passed
@melanieclarke
Copy link
Collaborator

Thanks for filing that - I noticed the failed builds this morning as well.

@braingram braingram deleted the stsci_image branch August 6, 2024 15:05
@braingram
Copy link
Collaborator Author

Thanks! Maybe we should finish support for 3.12 first 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace stsci.image with numpy functions
2 participants