-
Notifications
You must be signed in to change notification settings - Fork 177
JP-3628: Revise coron3 alignment step #8643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8643 +/- ##
=======================================
Coverage 60.47% 60.47%
=======================================
Files 369 369
Lines 38408 38413 +5
=======================================
+ Hits 23226 23230 +4
- Misses 15182 15183 +1 ☔ View full report in Codecov by Sentry. |
@penaguerrero - I'm not sure your solution here does what is required. It looks like you are computing the shifts from the first integration, as requested, but then you are shifting only the first integration. I think the shifts computed from the first integration need to be applied to all the subsequent ones. |
@melanieclarke thanks! brain freeze :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the behavior looks right now -- thanks for the update!
I think we could do a little better at the code refactoring, though, to avoid some unnecessary computations, and the docs need tweaking for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Maria! Just a few small comments. It might be good to do one more regtest just in case, after changes
Co-authored-by: Melanie Clarke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more suggestions for documentation clarity, but I think this looks good.
Can you please re-run the regression tests one more time?
Co-authored-by: Melanie Clarke <[email protected]>
Co-authored-by: Melanie Clarke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression test results look appropriate -- NIRSpec failures are all unrelated.
I think everything looks good now. Thanks for all the fixes!
Resolves JP-3628
Closes #
This PR addresses aligning only the first integration of the science exposure.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR