Skip to content

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Jul 12, 2024

Resolves JP-3628

Closes #

This PR addresses aligning only the first integration of the science exposure.

Checklist for PR authors (skip items if you don't have permissions or they are not applicable)

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • All comments are resolved
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner July 12, 2024 21:11
@penaguerrero penaguerrero added this to the Build 11.1 milestone Jul 12, 2024
@penaguerrero
Copy link
Contributor Author

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.47%. Comparing base (cf91724) to head (0dae781).

Files with missing lines Patch % Lines
jwst/coron/imageregistration.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8643   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         369      369           
  Lines       38408    38413    +5     
=======================================
+ Hits        23226    23230    +4     
- Misses      15182    15183    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@melanieclarke
Copy link
Collaborator

@penaguerrero - I'm not sure your solution here does what is required. It looks like you are computing the shifts from the first integration, as requested, but then you are shifting only the first integration. I think the shifts computed from the first integration need to be applied to all the subsequent ones.

@penaguerrero
Copy link
Contributor Author

@melanieclarke thanks! brain freeze :)

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the behavior looks right now -- thanks for the update!

I think we could do a little better at the code refactoring, though, to avoid some unnecessary computations, and the docs need tweaking for clarity.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Maria! Just a few small comments. It might be good to do one more regtest just in case, after changes

Co-authored-by: Melanie Clarke <[email protected]>
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more suggestions for documentation clarity, but I think this looks good.

Can you please re-run the regression tests one more time?

@penaguerrero
Copy link
Contributor Author

Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression test results look appropriate -- NIRSpec failures are all unrelated.

I think everything looks good now. Thanks for all the fixes!

@melanieclarke melanieclarke merged commit 4bd6549 into spacetelescope:master Jul 30, 2024
27 checks passed
@penaguerrero penaguerrero deleted the jp3628 branch August 7, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants