Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 11, 2025

  • Add RPATH support for custom OpenSSL libraries
  • Add comprehensive unit tests for RPATH functionality
  • Fix RSpec test stub to ensure bash resource runs during testing
  • Verify all unit tests pass
  • Ensure code passes cookstyle linting

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] OpenSSL doesn't compile correctly in the OpenSSL test suite Fix OpenSSL compilation on RHEL derivatives by adding RPATH support Sep 11, 2025
Copilot AI requested a review from damacus September 11, 2025 23:16
Copilot finished work on behalf of damacus September 11, 2025 23:16
@damacus damacus changed the title Fix OpenSSL compilation on RHEL derivatives by adding RPATH support fix: OpenSSL compilation on RHEL derivatives by adding RPATH support Sep 15, 2025
@damacus damacus marked this pull request as ready for review September 15, 2025 07:44
@damacus damacus requested a review from a team as a code owner September 15, 2025 07:44
@github-actions
Copy link

😰 RSpec failure

18 examples, 2 failures
Example Description Message
spec/unit/recipes/install_spec.rb:46 haproxy_install compile HAProxy with custom OpenSSL includes RPATH in the compilation command expected "bash[compile_haproxy]" with action :run to be in Chef run. Other bash resources: bash[compile_haproxy]
spec/unit/recipes/install_spec.rb:52 haproxy_install compile HAProxy with custom OpenSSL includes SSL_LIB and SSL_INC in the compilation command expected "bash[compile_haproxy]" with action :run to be in Chef run. Other bash resources: bash[compile_haproxy]

@github-actions
Copy link

Slowest examples

Top 10 slowest examples (1.07 seconds, 63.98% of total time)
Example Description Time in seconds
spec/unit/recipes/cache_spec.rb:45 haproxy_cache create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.14556
spec/unit/recipes/global_spec.rb:26 haproxy_config_global create haproxy config global is expected to render file "/etc/haproxy/haproxy.cfg" 0.13529
spec/unit/recipes/install_spec.rb:12 haproxy_install install haproxy using the package method is expected to install package "haproxy" 0.1268
spec/unit/recipes/fastcgi_spec.rb:63 haproxy_fastcgi create a fastcgi resource, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.12453
spec/unit/recipes/listen_spec.rb:106 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected not to render file "/etc/haproxy/haproxy.cfg" with content /use_backend admin0 if path_beg /admin0.*http-request add-header Test Value/m 0.09991
spec/unit/recipes/listen_spec.rb:39 haproxy_listen create template with a listen resource is expected to render file "/etc/haproxy/haproxy.cfg" 0.09554
spec/unit/recipes/defaults_spec.rb:26 haproxy_config_defaults create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.08877
spec/unit/recipes/mailer_spec.rb:48 haproxy_mailer create a mailer, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.08723
spec/unit/recipes/listen_spec.rb:61 haproxy_listen option parameter with array of options is expected to render file "/etc/haproxy/haproxy.cfg" 0.08572
spec/unit/recipes/peer_spec.rb:45 haproxy_peer create a peers section, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.08442

@damacus
Copy link
Member

damacus commented Oct 16, 2025

@copilot fix these rspec errors!

Copy link
Contributor Author

Copilot AI commented Oct 16, 2025

@copilot fix these rspec errors!

Fixed! The RSpec test was stubbing the command to return a truthy value, which caused the bash resource's not_if guard to prevent execution. Changed the stub to return false so the resource runs and can be tested properly. All tests now pass. (commit: 80e5a)

Copilot finished work on behalf of damacus October 16, 2025 11:05
@damacus damacus changed the title fix: OpenSSL compilation on RHEL derivatives by adding RPATH support fix(install): OpenSSL compilation on RHEL derivatives by adding RPATH support Oct 20, 2025
@damacus damacus changed the title fix(install): OpenSSL compilation on RHEL derivatives by adding RPATH support fix(Install): OpenSSL compilation on RHEL derivatives by adding RPATH support Oct 20, 2025
@github-actions
Copy link

Slowest examples

Top 10 slowest examples (1.08 seconds, 65.34% of total time)
Example Description Time in seconds
spec/unit/recipes/cache_spec.rb:45 haproxy_cache create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.14558
spec/unit/recipes/global_spec.rb:26 haproxy_config_global create haproxy config global is expected to render file "/etc/haproxy/haproxy.cfg" 0.13581
spec/unit/recipes/install_spec.rb:12 haproxy_install install haproxy using the package method is expected to install package "haproxy" 0.1334
spec/unit/recipes/fastcgi_spec.rb:63 haproxy_fastcgi create a fastcgi resource, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.11855
spec/unit/recipes/listen_spec.rb:105 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected to render file "/etc/haproxy/haproxy.cfg" 0.09913
spec/unit/recipes/peer_spec.rb:45 haproxy_peer create a peers section, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.09662
spec/unit/recipes/listen_spec.rb:39 haproxy_listen create template with a listen resource is expected to render file "/etc/haproxy/haproxy.cfg" 0.09612
spec/unit/recipes/defaults_spec.rb:26 haproxy_config_defaults create a cache, frontend and backend and verify config is created properly is expected to render file "/etc/haproxy/haproxy.cfg" 0.09086
spec/unit/recipes/frontend_backend_spec.rb:33 haproxy_frontend create frontend and backend with http-request rule placed before use_backend is expected to render file "/etc/haproxy/haproxy.cfg" 0.084
spec/unit/recipes/listen_spec.rb:106 haproxy_listen extra options http-request rule should be placed before use_backend rule is expected not to render file "/etc/haproxy/haproxy.cfg" with content /use_backend admin0 if path_beg /admin0.*http-request add-header Test Value/m 0.0839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants