- Used "this" in QProcess() instead of uninitialized pointer. #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgBisseling
commented
Oct 14, 2013
GeorgBisseling
commented
- Commented out lexer->setPaper in runCode
- Commented out lexer->setPaper in runCode
Collaborator
|
What is the motivation for this pull request? What is the specific problem you are solving and how does this solve it? |
Author
|
Essentially you are passing a random number to the QProcess() constructor. Either pass null or pass a proper parent. |
Collaborator
|
This commit also does more than just that though... If you can address one specific issue per pull request, it's easier for me to assess the impact, benefit and make use of it. |
Collaborator
|
Hi there, I've made huge modifications to the Qt GUI in Sonic Pi now. If you see anything that could be improved, do let me know. |
Closed
samaaron
added a commit
that referenced
this pull request
May 8, 2022
de7f8abb4 Merge pull request #29 from lilyinstarlight/linux-builtin-rtmidi 59114d1ae CI - remove rtmidi-dev from Linux build 3248ce923 Build - use built-in RtMidi by default on Linux git-subtree-dir: app/external/sp_midi git-subtree-split: de7f8abb45a609ad8359f436de86fd9ec441591a
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.