Skip to content

Conversation

@level-xx
Copy link
Contributor

It's been a long time ... here comes a complement to PR Synths winwood_lead, bass_foundation, and bass_highend #2628, (hopefully) fixing the license issues.

  • removed license stuff from docs in app/server/ruby/lib/sonicpi/synths/synthinfo.rb
  • updated LICENSE.md, using MIT for most and GPL for some synthdefs

@ethancrawford
Copy link
Collaborator

Seems ok to me 🙂
Let's see what Sam thinks 👍

@samaaron
Copy link
Collaborator

Looks good, but don't we also need the synthdefs themselves as part of this PR?

@ethancrawford
Copy link
Collaborator

@samaaron they were already merged to dev a while ago 🙂

@ethancrawford
Copy link
Collaborator

@samaaron
Copy link
Collaborator

I just checked, but can't see them in the tree.

@samaaron
Copy link
Collaborator

Oh wait, I was looking at the wrong branch :-)

@samaaron samaaron merged commit fb8a4c4 into sonic-pi-net:dev Oct 12, 2021
@samaaron
Copy link
Collaborator

Thanks so much for this :-)

@level-xx
Copy link
Contributor Author

Many thanks to you, too! So many interesting things to do with Sonic Pi, and so little time. But I sure will submit some more synthdefs, now that I know how it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants