Skip to content

Conversation

djekl
Copy link
Contributor

@djekl djekl commented Feb 23, 2025

Some files, for example src/Support/Frames.php have bad headings where you have updated the copyright.

<?php

/**
 * @author Aaron Francis <[email protected]>
 *
 * @link https://aaronfrancis.com
 * @link https://twitter.com/aarondfrancis
 */

declare(strict_types=1);

/**
 * @author Aaron Francis <[email protected]>
 *
 * @link https://aaronfrancis.com
 * @link https://x.com/aarondfrancis
 */

namespace SoloTerm\Solo\Support;

class Frames

I have gone through the files and updated these to all have the standardised one of

<?php

declare(strict_types=1);

/**
 * @author Aaron Francis <[email protected]>
 *
 * @link https://aaronfrancis.com
 * @link https://x.com/aarondfrancis
 */

Most files just needed the declare(strict_types=1); adding.

…ert the changes that added them in. I only added them as they were in one of the files I looked at which had the new copyright text.

This commit only changes this, so can be reverted if you choose to add this back, and deal with the strict types.
@djekl
Copy link
Contributor Author

djekl commented Feb 27, 2025

Declaring strict types breaks a lot of tests, so I am choosing to revert the changes that added them in. I only added them as they were in one of the files I looked at which had the new copyright text.

This commit only changes this, so can be reverted if you choose to add this back, and deal with the strict types.

@aarondfrancis
Copy link
Collaborator

Thank you! Guess I should look at strict types eh? Ha

@aarondfrancis aarondfrancis merged commit 7650203 into soloterm:main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants