-
Notifications
You must be signed in to change notification settings - Fork 57
interface: Split out instructions, state, errors from program #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface: Split out instructions, state, errors from program #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! mostly bits on the dependencies and CI, then we can get this in
e2824ea
to
81741bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last bit, then this is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Problem (as stated by @joncinque at token-2022 #616)
The SPL token program has some heavy dependencies that most users of the crate don't care about. This causes dependency issues and long compilation times.
Also, the program uses Agave dependencies, which creates circular dependencies and makes it impossible to upgrade to SDK v3 without some complicated gymnastics.
Summary of changes
Everything needed by Agave is now split into the spl-token-interface crate. On-chain programs can also use this as an rlib.