Skip to content

Switch MonixStreams to use Array[Byte] #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2020
Merged

Switch MonixStreams to use Array[Byte] #28

merged 1 commit into from
Nov 8, 2020

Conversation

ghostbuster91
Copy link
Contributor

Justification:

  • it seems that most of the monix related libraries works on Array[Byte] (e.g. monix-nio)
  • because we keep that in ByteBuffer rather than arrays, we have to convert whenever we interact with some of monix built in stuff, this currently means 3 places (compression, reading response from file, writing response to file)
  • by doing that we will decrease the number of places where we do conversion to one - we will convert as soon as we get ByteBuffer from HttpClient

@ghostbuster91 ghostbuster91 requested a review from adamw November 8, 2020 15:54
@adamw adamw merged commit 5a96285 into master Nov 8, 2020
@mergify mergify bot deleted the monix-byte-array branch November 8, 2020 17:24
@adamw
Copy link
Member

adamw commented Nov 8, 2020

Released in 1.0.0-RC8, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw Awaiting requested review from adamw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostbuster91 @adamw