Skip to content

Conversation

huanglongchao
Copy link
Contributor

@huanglongchao huanglongchao commented Mar 17, 2023

Motivation:

sofaregistry 由于大量的使用了固定延迟的批处理,导致推送延迟还是偏高,希望可以通过识别数据量,减少批处理的固定延迟,减少整体变更推送延迟。该Feature支持运行时动态配置攒批延时

Modification:

Describe the idea and modifications you've done.

Result:

Fixes #310

If there is no issue then describe the changes introduced by this PR.

@sofastack-bot
Copy link

sofastack-bot bot commented Mar 17, 2023

Hi @huanglongchao, welcome to SOFAStack community, Please sign Contributor License Agreement!

After you signed CLA, we will automatically sync the status of this pull request in 3 minutes.

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #309 (5e73504) into master (c9cbee4) will increase coverage by 0.13%.
The diff coverage is 83.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #309      +/-   ##
============================================
+ Coverage     76.40%   76.54%   +0.13%     
  Complexity       48       48              
============================================
  Files           493      495       +2     
  Lines         18249    18440     +191     
  Branches       1783     1800      +17     
============================================
+ Hits          13943    14114     +171     
- Misses         3502     3514      +12     
- Partials        804      812       +8     
Impacted Files Coverage Δ
.../registry/server/session/push/FirePushService.java 57.26% <0.00%> (-0.26%) ⬇️
...ofa/registry/server/session/push/RegProcessor.java 82.88% <30.76%> (-7.12%) ⬇️
...fa/registry/server/session/push/PushProcessor.java 78.03% <69.23%> (-0.74%) ⬇️
...a/registry/server/session/push/PushTaskBuffer.java 76.85% <78.57%> (+<0.01%) ⬆️
.../registry/server/session/push/ChangeProcessor.java 90.38% <85.71%> (-0.83%) ⬇️
.../providedata/FetchPushEfficiencyConfigService.java 87.50% <87.50%> (ø)
...rver/session/push/PushEfficiencyImproveConfig.java 90.00% <90.00%> (ø)
...egistry/common/model/constants/ValueConstants.java 93.33% <100.00%> (+0.31%) ⬆️
...rovidedata/AbstractFetchSystemPropertyService.java 68.08% <100.00%> (+0.69%) ⬆️
...y/sofa/registry/server/shared/util/DatumUtils.java 87.06% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9cbee4...5e73504. Read the comment docs.

@huanglongchao huanglongchao added this to the 6.3.0 milestone Mar 17, 2023
@huanglongchao huanglongchao force-pushed the release_630_push_efficiency_improvement branch 5 times, most recently from f07e5d7 to 203ef9f Compare March 23, 2023 07:00
@sofastack-bot sofastack-bot bot added size/XXL and removed size/XL labels Mar 23, 2023
@huanglongchao huanglongchao force-pushed the release_630_push_efficiency_improvement branch from 203ef9f to 07d1412 Compare March 23, 2023 09:38
@sofastack-bot sofastack-bot bot added cla:yes and removed cla:no labels Mar 23, 2023
@huanglongchao huanglongchao force-pushed the release_630_push_efficiency_improvement branch from 07d1412 to 5677b52 Compare March 23, 2023 10:17
@nocvalight nocvalight merged commit 7aee475 into sofastack:master Mar 31, 2023
nobodyiam pushed a commit to nobodyiam/sofa-registry that referenced this pull request Jul 5, 2023
* push delay time config

* fix review

---------

Co-authored-by: 江村 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

推送提效
3 participants