parent-namespace: change inline Adapter-like to file-private class #4950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
parentNamespace.adapterbe a dummy adapter-like object, and only supportsbroadcastoperation.New behavior
The same behavior, but with a class that will pass type check.
Other information (e.g. related issues)
When reading the code I saw the FIXME, so I thought the type check can be satisfied this way.
IMO except the type check the inline
{broadcast}adapter was not bad. It is arguably better in that unsupported operations will fail loudly instead of silently. So I'm not very confident of this PR. Opinions welcome 🙏🏽 .To pass type check while preserving the old fail-fast behavior, one could also
this.adapter = {broadcast} as Adapter;