Skip to content

Conversation

soburi
Copy link
Owner

@soburi soburi commented Sep 20, 2025

Summary

  • enable the on-board ILI9342C panel via a MIPI-DBI SPI controller and dedicate the CoreS3 display aliases
  • bump the SPI bus configuration to support the LCD and document running the LVGL sample for screen bring-up

Testing

  • cmake -B build -S samples/subsys/display/lvgl -DBOARD=m5stack_cores3/esp32s3/procpu (fails: Zephyr-sdk package not found in container)

https://chatgpt.com/codex/tasks/task_e_68ce38cf024483229cebfbe9d4f42dda

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines 47 to 52
mipi_dbi {
compatible = "zephyr,mipi-dbi-spi";
spi-dev = <&spi2>;
duplex = <SPI_HALF_DUPLEX>;
mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE";
write-only;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Define MIPI-DBI bus mode on ili9342c node

The duplex and mipi-mode properties are placed on the mipi_dbi controller node, but the bindings for ILI9xxx panels expect these attributes on the display device (mipi-dbi-spi-device.yaml). Because the child ili9342c node lacks them, the driver falls back to the default 4‑wire/full‑duplex configuration while no dc-gpios is provided. When the display driver initializes it will execute the 4‑wire path and unconditionally toggle a command/data GPIO that does not exist, causing a runtime fault as soon as the display is enabled. Move duplex = <SPI_HALF_DUPLEX> and mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE" into the ili9342c@0 node so the driver uses 3‑wire mode without a DC pin.

Useful? React with 👍 / 👎.

@soburi soburi force-pushed the codex/add-display-support-for-m5stack-cores3 branch from a57b085 to 5029813 Compare September 20, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant