Skip to content

chore(schema): seed schema trait filter with auth and protocol definition traits #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

chore(schema): seed schema trait filter with auth and protocol definition traits #1620

merged 1 commit into from
Jun 16, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jun 16, 2025 •
edited
Loading

  • augment the hard-coded list of included traits with meta-trait annotated authDefinition and protocolDefinition traits (aligns with spec but no change in codegen output)
  • avoid allocation of unused strings in schema codegen
  • adds unit tests for schema trait codegen

@kuhe kuhe requested a review from a team as a code owner June 16, 2025 18:29
@kuhe kuhe mentioned this pull request Jun 4, 2025
Open
2 tasks
@kuhe kuhe merged commit 2aa00e6 into smithy-lang:main Jun 16, 2025
11 checks passed
@kuhe kuhe deleted the schemas branch June 16, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@siddsriv siddsriv siddsriv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @siddsriv