-
Notifications
You must be signed in to change notification settings - Fork 215
publish codegen artifacts to maven central #4218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d12b2b6
to
3d75fe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, couple of questions about the python/typescript bindings for the server, but those aren't blockers
kotlin("jvm") | ||
`maven-publish` | ||
id("smithy-rs.kotlin-conventions") | ||
id("smithy-rs.publishing-conventions") | ||
} | ||
|
||
description = "Generates Rust/Python server-side code from Smithy models" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we discussed not publishing the Typescript bindings, but I'm not terribly convinced that we should publish the Python bindings either. I guess people are using them? But my understanding is that support is pretty minimal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably up to @drganjoo, I'm ok either way as these are all pre-GA versions for codegen with no backwards compat or stability guarantees.
684ac71
to
74955f4
Compare
c557090
to
5c162bd
Compare
5c162bd
to
cf5f52f
Compare
Motivation and Context
Publish codegen artifacts to Maven Central so users can generate Rust clients + servers without cloning smithy-rs and patching our build files.
Description
gradle.properties
has been updated if any codegen project has changedcodegen-server/python
->codegen-server/codegen-server-python
codegen-server/typescript
->codegen-server/codegen-server-typescript
aws/sdk-codegen
->aws/codegen-aws-sdk
TODO
Need to decide on artifact names. We can probably live with most of them but the python/typescript artifacts don't indicate anything server specific and thesdk-codegen
one doesn't indicate "AWS SDK" specific. Generally we don't publish the AWS SDK specific codegen but we tied up a lot of the "AWS specific" stuff like sigv in that module so seems like we might need to publish it as well for it to be of use. Open to discussion though.Need to finish configuring secretsPublish GPG keys, for some reason this is still not working I may need to switch machines to try it onComplete additional dry run release testingTesting
Checklist
.changelog
directory, specifying "client," "server," or both in theapplies_to
key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.