Add standard retry mode #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgromero
force-pushed
the
standard-retries
branch
from
fc2a957 to
56af01b
Compare
alexgromero
commented
Aug 22, 2025
jonathan343
previously requested changes
Sep 2, 2025
Contributor
jonathan343
left a comment
jonathan343
left a comment
There was a problem hiding this comment.
Thanks Alessandra!
Looks great so far. I have a few suggestions below.
SamRemis
requested changes
Oct 13, 2025
alexgromero
force-pushed
the
standard-retries
branch
from
56af01b to
006c5e2
Compare
nateprewitt
reviewed
Nov 12, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Looks like we're off to a good start. I left some high-level feedback, but let me know if I can clarify anything!
Co-authored-by: Nate Prewitt <[email protected]>
nateprewitt
reviewed
Nov 14, 2025
nateprewitt
previously approved these changes
Nov 18, 2025
alexgromero
dismissed
nateprewitt’s stale review
The base branch was changed.
SamRemis
approved these changes
Nov 18, 2025
alexgromero
dismissed
jonathan343’s stale review
Addressed @jonathan343's comments.
SamRemis
pushed a commit
to SamRemis/smithy-python
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for a new retry mode:
standard. This behavior is now consistent with other AWS SDKs implementing standard mode. This mode also adds support for retry quotas which control how many unsuccessful retries a client can make.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.