-
Notifications
You must be signed in to change notification settings - Fork 502
Multiple roots and federation #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
==========================================
+ Coverage 71.81% 76.15% +4.33%
==========================================
Files 19 20 +1
Lines 1451 1652 +201
==========================================
+ Hits 1042 1258 +216
+ Misses 296 280 -16
- Partials 113 114 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR adds support for federated roots, and multiple roots for root rotation. Fixes #19
Federated roots are a list of public certificates that a client can include and trust, a new endpoint (
/federation
) has been added that returns the server roots as well as the federated ones.The CA now supports one or multiple roots in the
root
property of the JSON, that property is able to unmarshal both strings and arrays, the latter must be always used for multiple roots. The SDK is able to update the root certificates on each renew, and this feature can be used for root rotation following this process:A known issue is that at this moment rootA won't be removed, but a new issue with a strategy to support that has been created.