Skip to content

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Nov 28, 2018

Description

Force the renew of the CA server cert if it's about to expire. This only happens after a wake up after a hibernation if enough time has passed to expire the certificate.

This PR only solves the problem for the CA server and not server or clients using CA certificates, as those won't be able to use TLS requests with expired certs.

@maraino maraino requested a review from dopey November 28, 2018 00:01
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #11 into master will increase coverage by 0.89%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   70.85%   71.75%   +0.89%     
==========================================
  Files          19       19              
  Lines        1431     1448      +17     
==========================================
+ Hits         1014     1039      +25     
+ Misses        306      296      -10     
- Partials      111      113       +2
Impacted Files Coverage Δ
ca/ca.go 45.78% <50%> (-0.56%) ⬇️
ca/renew.go 75.3% <94.44%> (+19.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63f4f0...7e2f80a. Read the comment docs.

@maraino maraino merged commit eaa9bc5 into master Nov 28, 2018
@maraino maraino deleted the ca-force-renew branch November 28, 2018 00:47
maraino added a commit that referenced this pull request May 20, 2020
Implementation is based on the PKCS #11 URI Scheme RFC
https://tools.ietf.org/html/rfc7512
maraino added a commit that referenced this pull request Jan 27, 2021
The implementation works with YubiHSM2. Unit tests are still pending.

Fixes #301
@maraino maraino mentioned this pull request Jan 27, 2021
3 tasks
maraino added a commit that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants