Skip to content

Conversation

@lynnemorrison
Copy link
Collaborator

@lynnemorrison lynnemorrison commented Aug 18, 2025

When creating a site verify the namespace configured follows proper format.

fixes #2207

@fgiorgetti
Copy link
Member

fgiorgetti commented Aug 19, 2025

The validation itself looks ok to me, but it has to be applied to all create, delete and update commands for all resources, in order to close #2207. As is, if someone tries to create a listener or any other resource using an invalid namespace, it is still allowed.

Copy link
Member

@fgiorgetti fgiorgetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation seems to work. The validation is still missing in the token redeem command.

@lynnemorrison
Copy link
Collaborator Author

Validation seems to work. The validation is still missing in the token redeem command.

Sorry about that. I didn't realize tokens were used in nonkube, I only looked at the token issue command and saw it wasn't implemented and didn't look at the redeem command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace characters should be validated on system sites

3 participants