Added s390x arch in Makefiles to build multi arch images and skipped some tests on s390x because of image unavailability #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…some tests on s390x because of image unavailability
hash-d
requested changes
Sep 18, 2025
There was a problem hiding this comment.
For the tests that cannot be run on Z because of missing images, the cluster's architecture should be checked, instead of the local test machine.
If you're running from an x86 VM pointing to a Z cluster, for example, those tests would not be skipped and the test would fail.
| ) | ||
|
|
||
| func TestBookinfo(t *testing.T) { | ||
| if runtime.GOARCH == "s390x" { |
There was a problem hiding this comment.
Checking runtime.GOARCH is ok for testLocalGatewayService, because that's a local test. For TestBookInfo, however, you should be inspecting the cluster's architecture, not the local machine.
Check how that's done for ARM, you can adapt that for Z.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added s390x arch in Makefiles to build multi arch images and
Skipping below tests on s390x because of image unavailability :
cc: @hash-d