Allow the database file to live in a nested subdirectory #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running essentially `git-history file data/pipelines.db data/pipelines.json` and getting empty databases. Iterating over `commit.tree.blobs` only looks for files in the top level directory. Since my data was nested, I needed to iterate over `commit.tree.trees` also. According to some experimentation and the python-git docs, this path-like syntax should work for deeply nested files.
|
FWIW, the main part of this change is also present in #52 (though your |
|
Ah cool; I'm happy to close this in favor of #52 then. Whichever one you want to merge! Let me know if you'd like to see any changes to get this one merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running essentially
git-history file data/pipelines.db data/pipelines.jsonand getting empty databases. Iterating overcommit.tree.blobsonly looks for files in the top level directory. Since my data was nested, I needed to iterate overcommit.tree.treesalso. According to some experimentation and the python-git docs, this path-like syntax should work for deeply nested files.