_internal/fulcio: refactor SCT model #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces `FulcioSignedCertificateTimestamp` with `FulcioSCT`, which inherits from `pydantic.BaseModel` and uses pydantic's verification APIs instead of doing all verification ad-hoc in the constructor. The relationship to `cryptography.x509.SignedCertificateTimestamp` is maintained via virtual subclassing. Signed-off-by: William Woodruff <[email protected]>
woodruffw
added
component:signing
woodruffw
commented
May 18, 2022
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
May 18, 2022
di
reviewed
May 19, 2022
di
previously approved these changes
May 19, 2022
Signed-off-by: William Woodruff <[email protected]>
We're able to get this fidelity with the round-trip, after all. Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
di
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
FulcioSignedCertificateTimestampwithFulcioSCT,which inherits from
pydantic.BaseModeland uses pydantic'sverification APIs instead of doing all verification ad-hoc in
the constructor.
The relationship to
cryptography.x509.SignedCertificateTimestampis maintained via virtual subclassing.
This should make testing detached SCTs much easier. Marking as a draft until I add some corresponding tests.
Signed-off-by: William Woodruff [email protected]