Skip to content

Conversation

woodruffw
Copy link
Member

Removes another top-level config file.

Signed-off-by: William Woodruff [email protected]

Removes another top-level config file.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added qa quality assurance component:cicd CI/CD labels May 11, 2022
@woodruffw woodruffw self-assigned this May 11, 2022
@woodruffw
Copy link
Member Author

CI is currently failing due to a potential regression in pip; ref pypa/pip#11110

di
di previously approved these changes May 12, 2022
@woodruffw
Copy link
Member Author

🤦

🔥🔥🔥🔥🔥Running security check🔥🔥🔥🔥🔥🔥
Using config file: pyproject.toml
[main]	ERROR	pyproject.toml : toml parser not available, reinstall with toml extra
b'[main]\tERROR\tpyproject.toml : toml parser not available, reinstall with toml extra\n'
🔥🔥🔥🔥Security check failed🔥🔥🔥🔥

@woodruffw
Copy link
Member Author

I'll fix this in a moment. I think we should probably just get rid of the third party action (it seems to be a fork of a fork and not actively maintained?) and run bandit directly.

@di
Copy link
Member

di commented May 12, 2022

Makes sense to me.

@woodruffw
Copy link
Member Author

Okay, I made it one of our dev deps and mashed it into make lint + our main lint action.

@woodruffw woodruffw merged commit 1426486 into main May 12, 2022
@woodruffw woodruffw deleted the ww/bandit-remove-config branch May 12, 2022 14:43
javanlacerda pushed a commit to javanlacerda/sigstore-python that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cicd CI/CD qa quality assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants