fulcio, _sign: Request certificates via CSR #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Cameron <[email protected]>
tetsuo-cpp
force-pushed
the
alex/csr-support
branch
from
5ea3819 to
84f74eb
Compare
|
I can confirm this works on the staging instance. CSR support hasn't been rolled out to prod yet so we shouldn't merge this right now. It'll be good to have this ready to go though. |
woodruffw
reviewed
May 10, 2022
di
approved these changes
May 10, 2022
woodruffw
added a commit
that referenced
this pull request
May 10, 2022
This reverts commit a000197.
woodruffw
added a commit
that referenced
this pull request
May 10, 2022
javanlacerda
pushed a commit
to javanlacerda/sigstore-python
that referenced
this pull request
Feb 23, 2024
* treewide: Use OIDC beacon instead of ambient credentials Signed-off-by: Alex Cameron <[email protected]> * action: Remove stale TODO Signed-off-by: Alex Cameron <[email protected]> * action: Use `ZipFile` context manager Signed-off-by: Alex Cameron <[email protected]> * action: Use `rstrip` to strip newline Signed-off-by: Alex Cameron <[email protected]> * action: Use `GITHUB_TOKEN` environment variable instead of having a custom one Signed-off-by: Alex Cameron <[email protected]> * README: Add `--identity-token` flag to protocol doc Signed-off-by: Alex Cameron <[email protected]> --------- Signed-off-by: Alex Cameron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29