-
Notifications
You must be signed in to change notification settings - Fork 63
run through stepsecurity hardener #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
970ead3
to
2346410
Compare
woodruffw
requested changes
May 10, 2022
Signed-off-by: Cam Parry <[email protected]>
Signed-off-by: Cam Parry <[email protected]>
ee04dba
to
5a14834
Compare
woodruffw
previously approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll make the PAT and then merge.
...or not: looks like one of the repo admins will need to do it (in which case it should be their PAT, not mine.) |
di
reviewed
May 12, 2022
di
approved these changes
May 12, 2022
javanlacerda
pushed a commit
to javanlacerda/sigstore-python
that referenced
this pull request
Feb 23, 2024
Signed-off-by: William Woodruff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ran .github workflows through https://app.stepsecurity.io/ as per ossf https://github.com/ossf/scorecard/blob/main/docs/checks.md. Also added ossf scorecard but it can also easily be added via https://github.com/marketplace/actions/ossf-scorecard-action, also needs a PAT as explained in the docs
Here is an example run from ossf scorecard https://app.stepsecurity.io/github/ossf/scorecard/actions/runs/2260401753.
If you add the detected endpoints, you can then turn into block mode if you wish and guarantee nothing will be added into the CI flow