Add a requirements file w/ hashes, and additional instructions for installing #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodruffw
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
LGTM!
One thought: I wonder whether we'll need some additional CI work to apply updates when pyproject.toml is changed manually?
For example, I can imagine a case where we bump cryptography and our requirements.txt is out-of-date for approximately a day, causing stale (or broken) installs.
|
Great point. I raised #115 to address this. |
javanlacerda
pushed a commit
to javanlacerda/sigstore-python
that referenced
this pull request
Feb 23, 2024
Instead of the in-toto statement, which does not have the right hash. Signed-off-by: Zach Steindler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a requirements file that users can optionally use when installing to enable hash-checking mode.
It also turns on Dependabot, to keep this file up to date.