Skip to content

_cli, _verify: Add --cert-oidc-issuer flag #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 4, 2022
Merged

_cli, _verify: Add --cert-oidc-issuer flag #112

merged 10 commits into from
Jun 4, 2022

Conversation

tetsuo-cpp
Copy link
Contributor

Closes #107

@tetsuo-cpp tetsuo-cpp force-pushed the alex/cert-oidc-provider branch from 513d512 to 083d218 Compare June 3, 2022 13:25
@tetsuo-cpp
Copy link
Contributor Author

It works like this:

$ sigstore verify test_file.txt --cert test_file.txt.crt --signature test_file.txt.sig --cert-email [email protected] --cert-oidc-issuer sigstore.dev
OK: test_file.txt

woodruffw
woodruffw reviewed Jun 3, 2022
View reviewed changes
tetsuo-cpp
tetsuo-cpp commented Jun 3, 2022
View reviewed changes
woodruffw
woodruffw reviewed Jun 3, 2022
View reviewed changes
tetsuo-cpp
tetsuo-cpp commented Jun 3, 2022
View reviewed changes
@woodruffw woodruffw added component:cli CLI components component:verification Core verification functionality labels Jun 3, 2022
woodruffw added 2 commits June 3, 2022 15:53
@woodruffw
README, cli: add more --help detail
9a9b921 
And fix a logging message.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
cli, verify: use OIDC issuer extension for issuer verification
0477877 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw requested a review from di June 3, 2022 21:04
woodruffw
woodruffw previously approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I also tweaked it a bit so someone else should additionally review.

tetsuo-cpp
tetsuo-cpp commented Jun 4, 2022
View reviewed changes
tetsuo-cpp
tetsuo-cpp commented Jun 4, 2022
View reviewed changes
tetsuo-cpp
tetsuo-cpp commented Jun 4, 2022
View reviewed changes
@woodruffw
verify: relocate model config
0fccc32 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw merged commit 1772dba into main Jun 4, 2022
@woodruffw woodruffw deleted the alex/cert-oidc-provider branch June 4, 2022 14:11
javanlacerda pushed a commit to javanlacerda/sigstore-python that referenced this pull request Feb 23, 2024
@bdehamer
add dsse bundle tests (sigstore#112)
303dd4b 
Signed-off-by: Brian DeHamer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haydentherapper haydentherapper haydentherapper left review comments

@woodruffw woodruffw woodruffw approved these changes

@di di Awaiting requested review from di

Assignees

@tetsuo-cpp tetsuo-cpp

Labels
component:cli CLI components component:verification Core verification functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sigstore verify should support --cert-oidc-provider
4 participants
@tetsuo-cpp @di @woodruffw @haydentherapper