Skip to content

fix: Error about missing .python-version file #1369 #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2022
Merged

fix: Error about missing .python-version file #1369 #1370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2af3da4
fix the default value of the perl-version-file input
shogo82148 Dec 12, 2022
08e5966
fallback to the default version 5
shogo82148 Dec 12, 2022
bb885a9
npm run format
shogo82148 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/setup-perl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,19 @@ async function resolveVersionInput(): Promise<string> {
return version;
}

const versionFilePath = path.join(process.env.GITHUB_WORKSPACE || "", versionFile || ".python-version");
version = await fs.readFile(versionFilePath, "utf8");
core.info(`Resolved ${versionFile} as ${version}`);
return version;
try {
const versionFilePath = path.join(process.env.GITHUB_WORKSPACE || "", versionFile || ".perl-version");
version = await fs.readFile(versionFilePath, "utf8");
core.info(`Resolved ${versionFile} as ${version}`);
return version;
} catch (err) {
if ((err as any)?.code !== "ENOENT" || versionFile) {
throw err;
}
}

// use the default version.
return "5";
}

run();