Feature/add vpl test #147
Open
Feature/add vpl test #147
+253
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adds new end-to-end tests for Intel VPL AV1 decoding and updates testing workflows to properly include the new test files. Key changes include:
- New AV1 decoder tests in tests/test_intel_vpl_av1.py that verify dynamic and large resolution switches.
- Updates to the GitHub Actions workflow files (.github/workflows/e2e-test-intel-vpl.yml and .github/workflows/e2e-test.yml) to include test files with revised naming patterns.
- Minor adjustments in tests/client.py and tests/test_intel_vpl.py, including the removal of outdated comments.
Reviewed Changes
| File | Description |
|---|---|
| tests/test_intel_vpl_av1.py | Added new tests for AV1 functionality under Intel VPL and resolution tests. |
| .github/workflows/e2e-test-intel-vpl.yml | Adjusted file patterns to include new test files. |
| tests/client.py | Introduced a duplicate definition of set_video_resolution. |
| .github/workflows/e2e-test.yml | Updated test file patterns for broader coverage. |
| tests/test_intel_vpl.py | Removed redundant comments regarding codec checks. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/client.py:315
- [nitpick] The set_video_resolution method is already defined elsewhere in the codebase, which may lead to confusion or unexpected behavior. Consider removing this duplicate definition and reusing the existing implementation.
def set_video_resolution(self, width: int, height: int):
tests/test_intel_vpl_av1.py:98
- [nitpick] The comment incorrectly refers to H.264/H.265, while the actual assertion checks for 'AV1'. Please update the comment to accurately reflect that the codec in use is AV1.
# H.264/H.265 が採用されているかどうか確認する
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and additions to the testing framework, particularly focusing on the Intel VPL and AV1 codec support. The most significant changes include expanding test coverage, adding new test cases, and updating existing tests to improve functionality and reliability.
Test Coverage Expansion:
tests/test_intel_vpl_av1.py: Added new test cases for Intel VPL with AV1 codec, including dynamic resolution changes and 8K resolution support. These tests ensure the system can handle different resolutions and codec implementations correctly.Workflow Updates:
.github/workflows/e2e-test-intel-vpl.yml: Modified the paths to include all files matchingtests/test_intel_vpl**and updated thepytestcommand to run tests for all matching files. This change ensures comprehensive test coverage for Intel VPL-related tests. [1] [2].github/workflows/e2e-test.yml: Updated the paths to include all files matchingtests/test_intel_vpl**andtests/test_apple_video_toolbox**, ensuring that changes to any related files trigger the appropriate tests.Code Improvements:
tests/client.py: Added a new methodset_video_resolutionto dynamically change the video resolution during tests. This method is used in the new AV1 tests to verify resolution changes.Minor Updates:
tests/test_intel_vpl.py: Removed redundant comments to clean up the code and improve readability. [1] [2]