Fix StartTLS ECONNRESET error when using tlsOptions #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn it! Bitnami takes openldap container image off the docker hub and paywalled it. I need to try a different image in order to run the tests. Sigh! |
|
Good job though @brycebaril ! |
|
@brycebaril , I have updated the upstream master branch to use symas/openldap container image for testing. Also updated three test cases to match the new ldap server's behavior. I hope it does not cause conflict with your changes! Can you rebase? |
- Fix: Exclude tlsOptions from Client constructor for ldap:// URLs - Fix: Only pass tlsOptions to startTLS() method, not constructor - Add: Comprehensive test suite for StartTLS functionality - Add: Documentation and examples for StartTLS usage - Update: docker-compose.yml image version for better availability This fixes the issue where using StartTLS with tlsOptions would cause an immediate ECONNRESET error. The problem was that tlsOptions were being passed to both the ldapts.Client constructor and the startTLS() method, causing a protocol conflict. According to ldapts documentation: - For ldaps:// URLs: pass tlsOptions to Client constructor - For ldap:// URLs with StartTLS: pass tlsOptions only to startTLS() The fix properly detects the protocol and routes tlsOptions accordingly, enabling StartTLS to work with self-signed certificates, SNI, and other TLS configuration options. Fixes shaozi#86
brycebaril
force-pushed
the
fix-starttls-econnreset
branch
from
4624bdb to
9d2b4b7
Compare
|
Thank you for taking a look! Rebased and force pushed. |
|
Released in v3.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where using StartTLS with tlsOptions would cause an immediate ECONNRESET error. The problem was that tlsOptions were being passed to both the ldapts.Client constructor and the startTLS() method, causing a protocol conflict.
According to ldapts documentation:
The fix properly detects the protocol and routes tlsOptions accordingly, enabling StartTLS to work with self-signed certificates, SNI, and other TLS configuration options.
Fixes #86