Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

Conversation

@jvarho
Copy link
Collaborator

@jvarho jvarho commented May 10, 2021

The past couple of versions of Next.js have an indication of whether the image component is imported in .next/export-marker.json so use it to avoid building image handler when not used.

Should prevent issues like #1030 for people upgrading with a restricted role.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #1065 (9d9de4d) into master (64a5a60) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   83.17%   83.19%   +0.02%     
==========================================
  Files          74       74              
  Lines        3049     3053       +4     
  Branches      864      867       +3     
==========================================
+ Hits         2536     2540       +4     
  Misses        460      460              
  Partials       53       53              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/build.ts 95.73% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a5a60...9d9de4d. Read the comment docs.

@jvarho jvarho force-pushed the check-image-imported branch from 2dcd84e to b3306bb Compare May 10, 2021 18:00
@dphang
Copy link
Collaborator

dphang commented May 10, 2021

Woops, looks like too many workflows were run at the same time, so we hit the GitHub API rate limit. Will try the workflow again after a few hours.

@dphang dphang merged commit 7372bf2 into master May 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the check-image-imported branch May 11, 2021 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants