Skip to content

Conversation

@Nerivec
Copy link
Contributor

@Nerivec Nerivec commented Dec 14, 2024

Ended up refactoring quite a bit while investigating a bug (seems prebuilds are failing on more and more setups), figured a recap PR might help...

  • Fix outdated packages (that don't require more refactoring)
  • Update node version in test to match that of prebuild action
  • Update napi_versions to 8
  • Update prebuildify target to 20
  • Update (split) matrix
    • force tags where missing
    • add win32-arm64
    • fix outdated image for linux-x64 (centos7-devtoolset7 => almalinux-devtoolset11)
    • switch linux-arm64-lts to linux-arm64
  • Update artifact names with matrix.name to avoid conflicts (merged on download)
  • Fix lint in tests

TODO:

Feel free to update/split as desired.

@reconbot
Copy link
Member

This is amazing, thank you. I'm for adding dockcross/linux-riscv64 too. I'll merge as is and bring back the deploy the step.

@reconbot reconbot merged commit 5d157b1 into serialport:main Dec 23, 2024
@github-actions
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants