Skip to content

Conversation

thinkocapo
Copy link
Contributor

@thinkocapo thinkocapo commented Sep 12, 2023

Overview

This PR was opened in order to test the RN and RN Sentry SDK updates by krystofwoldrich, and to run the TDA tests against it. The TDA testing is tracked in sentry-demos/empower#277

  • See commands in 'Run Android'
  • Not evaluating 'Run iOS' section in this PR. It's old info that will be tested once the RN-Android release are uploaded to Github and TDA is running succesfully on it.
  • Moved several Troubleshooting sections to Troubleshooting.md, like 'How to Bootstrap a RN+Sentry App for First Time', so the README is more readable, and it's easier to find the Setup vs Run instructions.
  • Updated Version Dependencies for build tools.

@krystofwoldrich
Copy link
Contributor

I have some small suggestions, but overall looks good. 👍

I haven't commented on the todos in trouble shooting as they will be addressed in sentry-demos/empower#277

thinkocapo and others added 7 commits September 27, 2023 09:56
Co-authored-by: Kryštof Woldřich <[email protected]>
Co-authored-by: Kryštof Woldřich <[email protected]>
Co-authored-by: Kryštof Woldřich <[email protected]>
Co-authored-by: Kryštof Woldřich <[email protected]>
Co-authored-by: Kryštof Woldřich <[email protected]>
includeSourceContext true
assembleRelease comment
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed one more version with "?".

Thanks for writing all the commands. It's a handy guide.

@thinkocapo thinkocapo merged commit 3d130a4 into sentry-demos:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants