Remove the explicit Guzzle dependency #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the hard dependency on Guzzle by introducing a Transport abstraction layer, which allows using different HTTP clients. Add more granular exceptions which all extend the base SendyException.
Change SendyException into an interface to allow extending native exceptions like JsonException.
The symfony/http-client and friendsofphp/php-cs-fixer dev dependencies relied on symfony/polyfill-php80. This caused PHPStan to not warn about using the str_starts_with function in a PHP 7.4 project.
These will be moved to their respective repositories when upgrading to version 3 of the Sendy SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request the SDK will be made client agnostic while trying to maintain backwards compatibility. The connection now will depend on a
Transportwhich will be created by theTransportFactoryif it is not supplied.