Skip to content

Conversation

tean-lai
Copy link
Contributor

@tean-lai tean-lai commented Jun 2, 2025

Updated some tests that previously considered constant strings to not be constant, leading to some incorrect matches.

Also added a negative test case.

Copy link
Collaborator

@LewisArdern LewisArdern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm gamers

@tean-lai tean-lai enabled auto-merge (squash) June 4, 2025 18:31
@tean-lai tean-lai merged commit d375208 into develop Jun 4, 2025
8 of 9 checks passed
@tean-lai tean-lai deleted the tean/query-set-extra branch June 4, 2025 19:25
inkz added a commit that referenced this pull request Jul 23, 2025
* fix query-set-extra tests (#3635)

Co-authored-by: Lewis <[email protected]>

* Update TLS version info in Go missing-ssl-minversion

Closes #3643

* Regex update - Missing integrity HTML rule

* new line

* Add detail to message for TF GCP bucket access

The message here was pretty vague and unhelpful - this adds some more specificity.

* Update semgrep-rules-test-develop.yml (#3658)

* Fix csharp-sqli sanitizers

* update CWEs for terraform rules (#3666)

---------

Co-authored-by: tean-lai <[email protected]>
Co-authored-by: Lewis <[email protected]>
Co-authored-by: Ville Skyttä <[email protected]>
Co-authored-by: gobind-singh <[email protected]>
Co-authored-by: Alexis Grant <[email protected]>
Co-authored-by: Claudio <[email protected]>
Co-authored-by: Alexis Grant <[email protected]>
Co-authored-by: Vladislav Timakov <[email protected]>
Co-authored-by: Kurt Boberg <[email protected]>
Co-authored-by: Vasilii Ermilov <[email protected]>
inkz added a commit that referenced this pull request Jul 25, 2025
* fix query-set-extra tests (#3635)

Co-authored-by: Lewis <[email protected]>

* Update TLS version info in Go missing-ssl-minversion

Closes #3643

* Regex update - Missing integrity HTML rule

* new line

* Add detail to message for TF GCP bucket access

The message here was pretty vague and unhelpful - this adds some more specificity.

* Update semgrep-rules-test-develop.yml (#3658)

* Fix csharp-sqli sanitizers

* update CWEs for terraform rules (#3666)

---------

Co-authored-by: tean-lai <[email protected]>
Co-authored-by: Lewis <[email protected]>
Co-authored-by: Ville Skyttä <[email protected]>
Co-authored-by: gobind-singh <[email protected]>
Co-authored-by: Alexis Grant <[email protected]>
Co-authored-by: Claudio <[email protected]>
Co-authored-by: Alexis Grant <[email protected]>
Co-authored-by: Vladislav Timakov <[email protected]>
Co-authored-by: Kurt Boberg <[email protected]>
Co-authored-by: Vasilii Ermilov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants