Javascript Drizzle ORM Raw SQL #3628
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@p4p3r If you have a moment to review, I'd appreciate. It's a rule request from the folks at Replit! |
kurt-r2c
previously approved these changes
Jun 2, 2025
kurt-r2c
dismissed
their stale review
dismissing so I can mark up some of the linter output
kurt-r2c
requested changes
Jun 2, 2025
| - patterns: | ||
| - pattern-either: | ||
| - pattern-inside: | | ||
| const { sql } = require('drizzle-orm') |
There was a problem hiding this comment.
Explicit const/var/let here necessitates coverage of the other two, unless you are certain that this will only ever be a const import. Not making this change will cause CI to throw linter errors on this rule.
| - patterns: | ||
| - pattern-either: | ||
| - pattern-inside: | | ||
| const $DRIZZLE = require('drizzle-orm') |
| import { sql as $ALIAS } from 'drizzle-orm' | ||
| ... | ||
| - pattern-inside: | | ||
| const { sql: $ALIAS } = require('drizzle-orm') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rules to prevent string concatenation in query when using Drizzle ORM
raw()function.Reference: https://orm.drizzle.team/docs/sql#sqlraw