Skip to content

feat(node-version): raised the minimum required version to v14.17 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021
Merged

feat(node-version): raised the minimum required version to v14.17 #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ jobs:
strategy:
matrix:
node-version:
- 10
- 12
- 14
- '14.17'
- 16
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -25,6 +24,8 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: npm
- run: npm ci
- name: Ensure dependencies are compatible with the version of node
run: npx ls-engines
- run: npm run test:ci
test:
runs-on: ubuntu-latest
Expand Down
70 changes: 36 additions & 34 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@
"clear-module": "4.1.1",
"codecov": "3.8.3",
"nyc": "15.1.0",
"semantic-release": "17.4.7",
"semantic-release": "18.0.0",
"sinon": "11.1.2",
"tempy": "1.0.1",
"xo": "0.28.3"
},
"engines": {
"node": ">=10.18"
"node": ">=14.17"
},
"files": [
"lib",
Expand Down Expand Up @@ -61,7 +61,7 @@
"all": true
},
"peerDependencies": {
"semantic-release": ">=15.8.0 <18.0.0"
"semantic-release": ">=18.0.0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the peerDependency of semantic-release requires >=18, may need to update the documentation/release notes since installing this version of changelog still results unsupported engine warnings.

},
"prettier": {
"printWidth": 120,
Expand Down