Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integrations/madkudu/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ var integration = require('@segment/analytics.js-integration');
* UMD?
*/

var umd = typeof window.define === 'function' && window.define.amd;
var umd = typeof window.define === 'function' && window.define.amd && window.require;

/**
* Expose `Madkudu` integration.
Expand Down
2 changes: 1 addition & 1 deletion integrations/madkudu/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-madkudu",
"description": "The Madkudu analytics.js integration.",
"version": "2.0.1",
"version": "2.0.2",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
6 changes: 5 additions & 1 deletion integrations/pinterest-tag/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ Pinterest.prototype.identify = function(identify) {
};

Pinterest.prototype.page = function(page) {

console.log('Hello from page event');
// If we have a category, the use ViewCategory. Otherwise, use a normal PageVisit.
if (page.category()) {
window.pintrk('track', 'ViewCategory', {
Expand All @@ -72,6 +74,7 @@ Pinterest.prototype.track = function(track) {
var pinterestEvent = this.getPinterestEvent(segmentEvent);
var pinterestObject = this.generatePropertiesObject(track);

console.log('Hello from track event');
if (pinterestEvent) {
window.pintrk('track', pinterestEvent, pinterestObject);
} else {
Expand Down Expand Up @@ -130,7 +133,8 @@ Pinterest.prototype.createPropertyMapping = function() {
variant: 'product_variant',
price: 'product_price',
quantity: 'product_quantity',
brand: 'product_brand'
brand: 'product_brand',
messageId: 'event_id'
};
};

Expand Down
2 changes: 1 addition & 1 deletion integrations/pinterest-tag/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-pinterest-tag",
"description": "The Pinterest Tag analytics.js integration.",
"version": "1.2.3",
"version": "1.2.4",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
14 changes: 11 additions & 3 deletions integrations/walkme/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ WalkMe.prototype.initialize = function() {

var env = (this.options.environment && this.options.environment.toLowerCase());

if (!env || env == "\/" || env == "\/production") {
if (env === "/" || env === "/production") {
env = "";
}

Expand Down Expand Up @@ -71,12 +71,20 @@ WalkMe.prototype.initialize = function() {
var bucket = (this.options.customDirectory) ? this.options.customDirectory : 'users';
var url = 'https://cdn.walkme.com/' + bucket + '/' + walkMeSystemId + '/' + env + '/walkme_' + sriSuffix + walkMeSystemId + '_https.js';

this.load({
var payload = {
url,
hash: this.options.integrityHash
});
};

this.initializeTester(payload);
this.load(payload);
};

/**
* Used for testing initialization
*/
WalkMe.prototype.initializeTester = function () {};

/**
* Has the WalkMe library been loaded yet?
*
Expand Down
2 changes: 1 addition & 1 deletion integrations/walkme/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@walkme/analytics.js-integration-walkme",
"description": "The WalkMe analytics.js integration.",
"version": "1.1.0",
"version": "1.2.1",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
2 changes: 1 addition & 1 deletion integrations/walkme/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,4 +238,4 @@ describe('WalkMe', function() {
}).timeout(10000);
});
});
});
});