HGI 81 - Add event ID to page calls sent to FB Pixel for deduplication #701
Conversation
sayan-das-in
changed the title
sayan-das-in
changed the title
|
|
||
| FacebookPixel.prototype.page = function() { | ||
| window.fbq('track', 'PageView'); | ||
| FacebookPixel.prototype.page = function(track) { |
There was a problem hiding this comment.
Should we also add a unit test to validate the new behavior?
|
@sayan-das-in The code looks good, but I think we should add at least one unit test to validate the new behavior/prevent future regressions. Thanks! |
Innovative-GauravKochar
requested review from
pooyaj and
varadarajan-tw
and removed request for
pooyaj
|
Hi there, I came across this PR by accident today, because we also have the deduplication problem. Are there any plans when this will be released? |
|
@pooyaj @Innovative-GauravKochar Maybe a stupid question, but when and how is it released? We are using the "Segment snippet" and Facebook Pageview Events are still duplicated... |
|
Hey @jony1993 - We are working on releasing it. The rollout is expected to be completed by 1-2 days. I will keep you posted. |
|
Hey @jony1993 - The changes should be available now. You can go ahead and test them. |
|
Hey @varadarajan-tw |
What does this PR do?
In Facebook Pixel and Facebook Conversions API (Actions) integrations, the eventId parameter is used to dedupe events, however Segment doesn't send eventId for Facebook Pixel Page events. This PR maps AJS messageId to Facebook's eventId.
Are there breaking changes in this PR?
No, this is a bug fix
Testing
Testing completed successfully in local environment with event tester
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
This PR is a bug fix which brings parity to Facebook Pixel Page Calls with Page Calls from Facebook Conversion API.
Does this require a new integration setting? If so, please explain how the new setting works
No
Links to helpful docs and other external resources
https://docs.google.com/document/d/19-PjSYJTH5tmKptMPXLBXPz3oF9c7sUpCSZ4TdyPYts