-
Notifications
You must be signed in to change notification settings - Fork 140
Removed nested objects from Braze identify and tracking calls #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
4b5dc44
c5c22d0
c05bd83
05d44a8
5fb1420
623b96f
9fa6119
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |
| "analytics.js", | ||
| "analytics.js-integration", | ||
| "segment", | ||
| "Braze", | ||
| "Appboy" | ||
| ], | ||
| "main": "lib/index.js", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -335,10 +335,11 @@ describe('Appboy', function() { | |||||
| ); | ||||||
| }); | ||||||
|
|
||||||
| it('should handle custom traits of all types', function() { | ||||||
| it('should handle custom traits of acceptable types and excludes nested hashes', function() { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. arrays are not objects?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
| analytics.identify('userId', { | ||||||
| song: "Who's That Chick?", | ||||||
| artists: ['David Guetta', 'Rihanna'], | ||||||
| details: { nested: 'object' }, | ||||||
| number: 16, | ||||||
| date: 'Tue Apr 25 2017 14:22:48 GMT-0700 (PDT)' | ||||||
| }); | ||||||
|
|
@@ -407,19 +408,23 @@ describe('Appboy', function() { | |||||
| analytics.called(window.appboy.logCustomEvent, 'event'); | ||||||
| }); | ||||||
|
|
||||||
| it('should send all properties', function() { | ||||||
| it('should send all properties except nested arrays and hashes', function() { | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| analytics.track('event with properties', { | ||||||
| nickname: 'noonz', | ||||||
| spiritAnimal: 'rihanna', | ||||||
| best_friend: 'han' | ||||||
| best_friend: 'han', | ||||||
| number_of_friends: 12, | ||||||
| idols: ['beyonce', 'madonna'], | ||||||
| favoriteThings: { whiskers: 'on-kittins' } | ||||||
| }); | ||||||
| analytics.called( | ||||||
| window.appboy.logCustomEvent, | ||||||
| 'event with properties', | ||||||
| { | ||||||
| nickname: 'noonz', | ||||||
| spiritAnimal: 'rihanna', | ||||||
| best_friend: 'han' | ||||||
| best_friend: 'han', | ||||||
| number_of_friends: 12 | ||||||
| } | ||||||
| ); | ||||||
| }); | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.