build(fmt): use [ instead of [[
#751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccojocar
approved these changes
Jan 3, 2022
|
@scop The build seems to be failing. Please could you have a look? Thanks |
|
@scop Please could you rebase your branch? The test should run now after upgrading ginkgo. |
When `/bin/sh` is not a shell having `[[`, `make fmt` fails: ``` FORMATTING /bin/sh: 1: [[: not found ```
scop
force-pushed
the
fix/makefile-bashism
branch
from
220f6e4 to
5c6c4ca
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
/bin/shis not a shell having[[,make fmtfails: