feature(formatter/text): Add color option on text format #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic color support for text format. For now, only the "Summary" title and "Issues" section has color
Given an issue, the file path is painted based on its severity. We're using the following rules: high is red, medium is yellow and low is simple black & white
It's only valid for text format
|
@ccojocar It's ready for review. Let me know what you think about it and feel free to add any suggestions. Thanks! |
ccojocar
approved these changes
Apr 14, 2020
|
I had to use the latest version of gookit/color package in order to get it working with tmux. Also I removed the flag and turned on by default. See #462 Thanks again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a flag
-colorto support colored output. This is only available for text output format.Using the gookit/color to have support for a range of OS.
Basic Examples
Text format without color flag on
Using other format than -fmt=text
It's not allowed to use that flag with other format types
No Issues
The
SummaryandIssuessections are presented coloredWith Issues
The file path is presented colored and also the
Issuesnumber is red when it's more than zeroHighseverityMediumseverityLowseverityOther examples
Running full example using different apps
Terminal App (Mac)
iTerm (Mac)
closes #456