Skip to content

cmd/tlsconfig: remove support for deprecated tls.VersionSSL30 #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2019
Merged

cmd/tlsconfig: remove support for deprecated tls.VersionSSL30 #412

merged 2 commits into from
Nov 19, 2019

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 8, 2019

The Go authors deprecated support for SSLv3 in go 1.13. They've decided to remove it in go 1.14, and have already merged the commit.

See: https://golang.org/issue/32716

This PR, or something like it, should probably land before February 2020.

@codecov-io
Copy link

codecov-io commented Nov 8, 2019 •
edited
Loading

Codecov Report

Merging #412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #412   +/-   ##
=======================================
  Coverage   71.28%   71.28%           
=======================================
  Files           9        9           
  Lines         599      599           
=======================================
  Hits          427      427           
  Misses        154      154           
  Partials       18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c76d4...c0c92a4. Read the comment docs.

ccojocar
ccojocar requested changes Nov 8, 2019
View reviewed changes
@alrs alrs force-pushed the remove-deprecated-sslv3 branch from 636757c to d459bb8 Compare November 8, 2019 18:01
ccojocar
ccojocar approved these changes Nov 13, 2019
View reviewed changes
@ccojocar
Copy link
Member

@alrs Please can you fix the build? Thanks!

@alrs alrs force-pushed the remove-deprecated-sslv3 branch 6 times, most recently from 2ae60f0 to c0c92a4 Compare November 13, 2019 19:38
ccojocar
ccojocar requested changes Nov 18, 2019
View reviewed changes
cmd/tlsconfig/tls_version_go12_go13.go Outdated
@@ -0,0 +1,33 @@
// +build !go1.14, !go1.11 go1.12,!go1.14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have twice !go.1.14? Looking at the file name, I think the build tags should be:

// +build go1.12, go1.13

@alrs
Copy link
Contributor Author

alrs commented Nov 18, 2019

My understanding of build tags is that go1.13 means "go 1.13 and later", and !go1.12 means "not go 1.12 or later."

https://golang.org/pkg/go/build/

@ccojocar
Copy link
Member

Thanks! You are right, I'm looking now at the build tags for go version compatibility. Just a small nit, you have go1.14 twice in tls_version_go12_go13.go. Please can you remove one tag? Thanks

@alrs alrs force-pushed the remove-deprecated-sslv3 branch from c0c92a4 to c02bc17 Compare November 19, 2019 09:59
@alrs
Copy link
Contributor Author

alrs commented Nov 19, 2019

Please can you remove one tag?

Done.

@ccojocar ccojocar merged commit df484bf into securego:master Nov 19, 2019
sthagen added a commit to sthagen/securego-gosec that referenced this pull request Dec 1, 2019
@sthagen
Merge pull request #2 from securego/master
1f6ee97 
cmd/tlsconfig: remove support for deprecated tls.VersionSSL30 (securego#412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccojocar ccojocar ccojocar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrs @codecov-io @ccojocar