Skip to content

Support Go 1.11 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2018
Merged

Support Go 1.11 #239

merged 2 commits into from
Sep 10, 2018

Conversation

dhui
Copy link
Contributor

@dhui dhui commented Sep 10, 2018

No description provided.

ccojocar
ccojocar approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccojocar ccojocar merged commit ec32ce6 into securego:master Sep 10, 2018
@dhui dhui deleted the go1.11 branch September 10, 2018 08:43
@MVrachev
Copy link
Contributor

MVrachev commented Sep 19, 2018 •
edited
Loading

Maybe I make a mistake somewhere but I still don't see the node module support in gosec from Go 1.11.
Here is an example:
image

I installed gosec a minute ago again to be sure that I am using the latest version of gosec.

@ccojocar
Copy link
Member

@MVrachev This is just for gosec itself, which now uses Go modules to manage its dependencies. The modules are not yet supported by the analyser. See this open issue #234.

@MVrachev
Copy link
Contributor

I am sorry. I misunderstood. :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccojocar ccojocar ccojocar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhui @MVrachev @ccojocar