update to G304 which adds binary expressions and file joining #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update to rule G304 gives gosec the ability to evaluate two path joining functions as well as binary expressions when inside
ioutil.Readfile
oros.Open
. Gosec can now flag cases like:ioutil.Readfile("/tmp/" + input + "/blob")
andos.Open(filepath.Join("/tmp/", file))
. To do this, a new function calledFindVarIdentities
was added to helpers.go. The function will return all variable identities found in a binary expression.