Skip to content

Make G204 look for CommandContext calls #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2018
Merged

Make G204 look for CommandContext calls #211

merged 3 commits into from
Jul 26, 2018

Conversation

WillAbides
Copy link
Contributor

exec.CommandContext is essentially the same thing as exec.Command. This PR makes gas treat it the same.

ccojocar
ccojocar approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAbides LGTM. Please could you fix the build?

@WillAbides
Copy link
Contributor Author

Merged master and fixed the build

ccojocar
ccojocar reviewed Jul 26, 2018
View reviewed changes
Copy link
Member

@ccojocar ccojocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ccojocar ccojocar merged commit 5ba6475 into securego:master Jul 26, 2018
@WillAbides WillAbides deleted the commandcontext branch July 26, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccojocar ccojocar ccojocar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WillAbides @ccojocar