JUnit XML output #160
Merged
JUnit XML output #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcmurphy
reviewed
Jan 29, 2018
output/formatter.go
Outdated
| raw = append(xmlHeader, raw...) | ||
| _, err = w.Write(raw) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
could we just return the error here instead of panic?
There was a problem hiding this comment.
opps. yes, should return an error here.
|
Thanks this looks a great addition. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new output format, namely:
JUnit XMLformat, following IBM's definition.This allows the results generated by
gasto be used by CI tools, like Jenkins, which are able to parse/readJUnit XMLresults in their various workflows.Example command to output
JUnit XML:This PR is in reference to #158.