Skip to content

Conversation

awiens
Copy link
Contributor

@awiens awiens commented Aug 3, 2017

This container can be built and run locally, in order to provide a simple way for users to run Gas on their code. The README has been updated to give information and provide build/run commands.

Copy link
Member

@gcmurphy gcmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for the current branch. Will need to revisit this when the 'experimental' branch is finally merged.

Couple of nitpicks -

  1. Can the line spacing be updated so there is one clear grouping of the 'builder' and another 'gas' tool.

Something like:

# Builds the thing
FROM ...
ENV .. 
COPY .. 
WORKDIR ... 
RUN ...

# Runs the thing
FROM ..
LABEL ..
COPY .. 
CMD ..
  1. We might also need to set the GOPATH environment variable either via the instructions or setting it in the Dockerfile.

  2. I'm not sure if you'll need to set a maintainer if this isn't something going to be published on dockerhub?

@awiens
Copy link
Contributor Author

awiens commented Aug 9, 2017

I think we are intending to publish to dockerhub at some point, but wanted to just get it up on github first

@gcmurphy gcmurphy merged commit f22c701 into securego:master Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants