gas produces legitimate warnings when run against itself

[endophage]

Results:

[/Users/david/go/src/github.com/GoASTScanner/gas/rules/fileperms.go:39] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > mode, _ = strconv.ParseInt(value.(string), 0, 64)


[/Users/david/go/src/github.com/GoASTScanner/gas/rules/sql.go:45] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > str, _ := gas.GetString(start)


[/Users/david/go/src/github.com/GoASTScanner/gas/rules/sql.go:80] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > arg, _ := gas.GetString(node.Args[0])


[/Users/david/go/src/github.com/GoASTScanner/gas/rules/tempfiles.go:32] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > arg, _ := gas.GetString(node.Args[0])


[/Users/david/go/src/github.com/GoASTScanner/gas/tools.go:118] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > root, _ := parser.ParseFile(fileset, filename, nil, parser.ParseComments)


[/Users/david/go/src/github.com/GoASTScanner/gas/tools.go:129] - Errors unhandled. (Confidence: HIGH, Severity: LOW)
  > pkg, _ := config.Check("main.go", fileset, []*ast.File{root}, info)


Summary:
   Files: 26
   Lines: 48936
   Nosec: 2
  Issues: 6

These all seem like things that can legitimately error so checks should probably be added. Particularly strconv.ParseInt.

[gcmurphy]

Fair call. I'll look at addressing these. One thing I've been wondering is if this error rule is useful or just too noisy. As I mentioned here: #54 I might look at explicitly blacklisting calls that can cause crashes if not checked. Have you got any preferences as to how this would work?

[endophage]

I've had some really annoying debugging sessions that resulted from silently ignoring an error so IMO it's completely worth while. Errors should at least be logged even if the code can happily continue.