Check for autoscale #336
Open
Check for autoscale #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to let AWS AutoScale win in a contest between dynamicDynamoDB and AWS Autoscale.
Our particular org is moving away from Dynamic-DynamoDB, and this change reflects that. Tables with autoscale policies will react faster in our experience. Others could benefit from this change, and in my testing I haven't seen this affect default behavior outside of the intended "don't poke auto-scaled tables."
I tried to follow patterns that I saw in the files I edited, and put the check just before the provision change to keep dynamic-dynamodb from hitting the AutoScale API a lot.