Skip to content
This repository was archived by the owner on Apr 7, 2023. It is now read-only.

Initial wrapper implementation #1

Merged
merged 14 commits into from
Mar 10, 2021
Merged

Initial wrapper implementation #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8b170e6
Fix comma-dangle issue
jonseitz Feb 17, 2021
a56a7a3
Create Oracle Wrapper
jonseitz Feb 17, 2021
d3a53ad
Namespace package under @seas-computing
jonseitz Feb 17, 2021
f52cd83
Updates typedoc to fix vulnerability
jonseitz Feb 17, 2021
9fe285f
Merge branch 'main' into develop
jonseitz Mar 8, 2021
01f8ff1
Allow overriding of more options
jonseitz Mar 10, 2021
3c26850
Log errors in catch blocks
jonseitz Mar 10, 2021
eb4b8de
Narrow use of eslint-disable
jonseitz Mar 10, 2021
cce04f2
Don't test unnecessary things
jonseitz Mar 10, 2021
6a7ade2
Move test data into its own file
jonseitz Mar 10, 2021
86791db
Import individual assert methods
jonseitz Mar 10, 2021
5881743
Provide message with fail() call
jonseitz Mar 10, 2021
fe5ebea
Make docblock spacing consistent
jonseitz Mar 10, 2021
d7d4759
Correct typo
jonseitz Mar 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@
"@typescript-eslint"
],
"rules": {
"@typescript-eslint/comma-dangle": [
Copy link

@rmainwork rmainwork Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned in our commit message that this is the fix for a conflict between two rules. Might this be better fixed upstream in seas-computing/boilerplate-library?

Copy link
Contributor Author

@jonseitz jonseitz Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. I think it would need to be updated in both places, actually. I'll make that in the seas-computing/boilerplate-library repo as well.

"error",
{
"arrays": "always-multiline",
"objects": "always-multiline",
"imports": "always-multiline",
"exports": "always-multiline",
"functions": "never"
}
],
"@typescript-eslint/indent": [
"error",
2
Expand Down
707 changes: 254 additions & 453 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

20 changes: 10 additions & 10 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "oracle-wrapper",
"name": "@seas-computing/oracle-wrapper",
"version": "0.0.0",
"description": "A lightweight wrapper about the oracledb driver",
"main": "lib/index.js",
Expand Down Expand Up @@ -30,24 +30,24 @@
},
"devDependencies": {
"@types/mocha": "^8.2.0",
"@types/node": "^14.14.20",
"@types/node": "^14.14.28",
"@types/oracledb": "^5.1.0",
"@types/sinon": "^9.0.10",
"@typescript-eslint/eslint-plugin": "^4.12.0",
"@typescript-eslint/parser": "^4.12.0",
"@typescript-eslint/eslint-plugin": "^4.15.1",
"@typescript-eslint/parser": "^4.15.1",
"codecov": "^3.8.1",
"eslint": "^7.17.0",
"eslint-config-airbnb-typescript": "^12.0.0",
"eslint": "^7.20.0",
"eslint-config-airbnb-typescript": "^12.3.1",
"eslint-import-resolver-node": "^0.3.4",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-mocha": "^8.0.0",
"mocha": "^8.2.1",
"mocha": "^8.3.0",
"nyc": "^15.1.0",
"oracledb": "^5.1.0",
"sinon": "^9.2.3",
"sinon": "^9.2.4",
"ts-node": "^9.1.1",
"typedoc": "^0.20.13",
"typescript": "^4.1.3"
"typedoc": "^0.20.25",
"typescript": "^4.1.5"
},
"dependencies": {}
}
Loading