feat(feynman): upgrade gas oracle predeploy

[Thegaram]

1. Purpose or design rationale of this PR

Upgrade L1GasOracle predeploy to scroll-tech/scroll-contracts#124 version at the Feynman transition block.

Local devnet logs:

INFO [06-25|10:57:43.011] Committing new mining work               number=29 sealhash=624f9b..96a8f2 txs=100 gas=2,100,000 fees=0.001017072
INFO [06-25|10:57:46.009] Successfully sealed new block            number=29 sealhash=624f9b..96a8f2 hash=f3cdfc..42d6f1
INFO [06-25|10:57:46.010] Applying Feynman hard fork 
INFO [06-25|10:57:46.044] Committing new mining work               number=30 sealhash=9138af..5c8fc2 txs=100 gas=2,100,000 fees=0.001017072
INFO [06-25|10:57:49.005] Successfully sealed new block            number=30 sealhash=9138af..5c8fc2 hash=298515..01f719

> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "penaltyFactor()(uint256)" --block 29
Error: server returned an error response: error code -32000: execution reverted
> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "penaltyFactor()(uint256)" --block 30
1000000000 [1e9]

> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "penaltyThreshold()(uint256)" --block 29
Error: server returned an error response: error code -32000: execution reverted
> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "penaltyThreshold()(uint256)" --block 30
1000000000 [1e9]

> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "isFeynman()(bool)" --block 29
Error: server returned an error response: error code -32000: execution reverted
> cast call --rpc-url http://127.0.0.1:8545 0x5300000000000000000000000000000000000002 "isFeynman()(bool)" --block 30
true

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• New Features
  • Introduced support for the Feynman hard fork, including automatic application of new protocol rules at the transition block.
  • Updated the L1GasPriceOracle contract with new bytecode and storage slots specific to the Feynman upgrade.
• Bug Fixes
  • Ensured that key storage slots are always included in execution witnesses for compatibility with external components.
• Documentation
  • Expanded documentation for contract storage layout and upgrade verification.
• Chores
  • Incremented the patch version to 58.

[coderabbitai]

Walkthrough

This update introduces the Feynman hard fork logic across the codebase. It adds detection for the Feynman transition block, applies new state changes and contract bytecode for the L1GasPriceOracle, updates storage slot constants, and increments the patch version. Several functions and method signatures are updated to accommodate the new fork handling.

Changes

File(s)	Change Summary
cmd/evm/internal/t8ntool/execution.go, core/state_processor.go, core/chain_makers.go	Add conditional logic to detect and apply Feynman hard fork state changes during block/state processing.
consensus/misc/feynman.go	Add ApplyFeynmanHardFork function to modify state for the Feynman fork, updating L1GasPriceOracle bytecode and storage.
miner/scroll_worker.go	Update method signatures to pass parent block, add Feynman fork application in handleForks.
eth/api.go	Ensure Feynman-specific storage slot is always included in execution witness for prover compatibility.
params/config.go	Add IsFeynmanTransitionBlock method to identify the Feynman fork transition block.
params/version.go	Increment patch version from 57 to 58.
rollup/rcfg/config.go	Add and document new storage slot constants, initial values, and bytecode for L1GasPriceOracle for Curie and Feynman forks.

Sequence Diagram(s)

sequenceDiagram
    participant BlockProcessor
    participant ChainConfig
    participant StateDB
    participant Misc

    BlockProcessor->>ChainConfig: IsFeynmanTransitionBlock(blockTime, parentTime)
    alt Feynman transition detected
        BlockProcessor->>Misc: ApplyFeynmanHardFork(StateDB)
        Misc->>StateDB: Update L1GasPriceOracle bytecode & storage slots
    end
    BlockProcessor->>StateDB: Continue with transaction/state processing

Loading

Suggested labels

bump-version

Suggested reviewers

• colinlyguo
• georgehao

Poem

A hop, a skip, a Feynman leap,
New forks and slots for state to keep.
The Oracle learns some brand new tricks,
With bytecode swaps and storage picks.
Patch fifty-eight, the chain’s delight—
Rabbits code through day and night! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5b7e2a and 403c79c.

📒 Files selected for processing (1)

• miner/scroll_worker.go (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• miner/scroll_worker.go

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: test
• GitHub Check: Analyze (go)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.